Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2940#discussion_r248985594
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java
---
@@ -75,8 +77,13 @@ public boolean equals(Object o) {
NewKafkaSpoutOffsetQuery that = (NewKafkaSpoutOffsetQuery) o;
if (topics != null ? !topics.equals(that.topics) : that.topics !=
null) return false;
- if (consumerGroupId != null ?
!consumerGroupId.equals(that.consumerGroupId) : that.consumerGroupId != null)
return false;
- return !(bootStrapBrokers != null ?
!bootStrapBrokers.equals(that.bootStrapBrokers) : that.bootStrapBrokers !=
null);
+ if (consumerGroupId != null ?
!consumerGroupId.equals(that.consumerGroupId) : that.consumerGroupId != null)
--- End diff --
I realize this was an issue before as well, but please add braces.
---
