srdo commented on issue #2939: STORM-3315: Upgrade to Kryo 4
URL: https://github.com/apache/storm/pull/2939#issuecomment-461429176
 
 
   I think making an automated test for this would be a big hassle. The test 
would need to download Storm 1.2.2 (or some other version using Kryo 3), and 
set it up in a cluster with a build of the current Storm version. We'd then 
need to run something like our integration test, and scan the logs for errors.
   
   Regarding how I decided which changes to make for Kryo 4, I'm just trusting 
the Kryo 4 release notes, which indicates that Kryo 3 and 4 are compatible if 
you set `setOptimizedGenerics(true)` (see 
https://github.com/EsotericSoftware/kryo/releases/tag/kryo-parent-4.0.0)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to