danny0405 commented on a change in pull request #2957: STORM-3335 allow timing
out when scheduling a topology
URL: https://github.com/apache/storm/pull/2957#discussion_r256701489
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/DefaultScheduler.java
##########
@@ -101,6 +101,10 @@ public void prepare(Map<String, Object> conf) {
//noop
}
+ @Override
+ public void cleanup() {
+ }
Review comment:
Most of the cleanup() method seems a no-op, can we define a default
implementation of it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
