srdo commented on issue #2957: STORM-3335 allow timing out when scheduling a 
topology
URL: https://github.com/apache/storm/pull/2957#issuecomment-463656866
 
 
   @agresch Thanks, it looks great. I'm wondering if we can put the setup and 
cleanup in `@Before/@After` for many of the tests? Ideally we'd avoid leaking 
threads even when the tests fail, so cleanup should be either in an `@After` or 
in try-finally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to