Ethanlm commented on a change in pull request #2957: STORM-3335 allow timing 
out when scheduling a topology
URL: https://github.com/apache/storm/pull/2957#discussion_r258515801
 
 

 ##########
 File path: 
storm-server/src/test/java/org/apache/storm/scheduler/blacklist/TestBlacklistScheduler.java
 ##########
 @@ -74,6 +85,7 @@ public void TestBadSupervisor() {
         Cluster cluster = new Cluster(iNimbus, resourceMetrics, supMap, new 
HashMap<>(), topologies, config);
         BlacklistScheduler bs = new BlacklistScheduler(new DefaultScheduler(), 
metricsRegistry);
         bs.prepare(config);
+        scheduler = bs;
 
 Review comment:
   I think it doesn't matter. But we could just use `scheduler = new 
BlacklistScheduler(new DefaultScheduler(), metricsRegistry);` directly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to