agresch commented on a change in pull request #2957: STORM-3335 allow timing
out when scheduling a topology
URL: https://github.com/apache/storm/pull/2957#discussion_r258549982
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
##########
@@ -331,6 +331,10 @@ protected SolverResult backtrackSearch(SearcherState
state) {
return new SolverResult(state, false);
}
+ if (Thread.currentThread().isInterrupted()) {
Review comment:
My remembrance from previous googling is that a cancel on the future causes
the thread to be interrupted, but it is up to that thread to respond to the
interrupt. If the scheduling thread is stuck in a long loop, it will just keep
running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
