srdo commented on a change in pull request #2945: STORM-3321: Fix race in
LocalCluster regarding Nimbus leadership, red…
URL: https://github.com/apache/storm/pull/2945#discussion_r262838943
##########
File path: storm-client/src/jvm/org/apache/storm/testing/FixedTupleSpout.java
##########
@@ -131,8 +130,6 @@ public void nextTuple() {
String id = UUID.randomUUID().toString();
_pending.put(id, ft);
_collector.emit(ft.stream, ft.values, id);
- } else {
- Utils.sleep(100);
Review comment:
Storm already sleeps between nextTuple calls if nothing is emitted based on
the sleep strategy. The extra sleep here doesn't do much for us I think, and
manually sleeping in nextTuple is a bad habit I'd like to discourage (it blocks
other message processing for the spout, e.g. ack handling).
See
https://github.com/apache/storm/blob/b07413670fa62fec077c92cb78fc711c3bda820c/storm-client/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java#L224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
