srdo commented on a change in pull request #2974: STORM-3355: Use
supervisor.worker.shutdown.sleep.secs to set worker s…
URL: https://github.com/apache/storm/pull/2974#discussion_r266111811
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
##########
@@ -127,7 +127,9 @@ public static void main(String[] args) throws Exception {
Worker worker = new Worker(conf, null, stormId, assignmentId,
Integer.parseInt(supervisorPort),
Integer.parseInt(portStr), workerId);
worker.start();
- Utils.addShutdownHookWithForceKillIn1Sec(worker::shutdown);
+ LOG.info("Adding shutdown hook with kill in {} secs",
ObjectReader.getInt(conf.get(Config.SUPERVISOR_WORKER_SHUTDOWN_SLEEP_SECS)));
Review comment:
Good catch, will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
