srdo opened a new pull request #2980: STORM-3361: Include dependency license file in distributions, clean u… URL: https://github.com/apache/storm/pull/2980 …p license merges a bit, make storm-dist use NOTICE/LICENSE from project root https://issues.apache.org/jira/browse/STORM-3361 The change here is so we include a DEPENDENCY-LICENSES file in our distributions and source listing our dependencies and their licenses. Regarding the new file, it is generated by running the license plugin as described in DEVELOPER. Ideally we will regenerate it before each release. It is being committed to git so it will be present in source releases. If we can generate it instead as part of the storm-dist/source build, that would probably be better though. There were NOTICE/LICENSE files in storm-dist/binary that are being included in distributions. To me it looks like they are supposed to be the same files as the ones we have in the project root, but I don't see why we would want to have a copy in storm-dist instead of just reading the root files.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
