srdo commented on a change in pull request #2984: [STORM-3365] Configuration to
disable Topology Lag Monitoring
URL: https://github.com/apache/storm/pull/2984#discussion_r270619355
##########
File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java
##########
@@ -1618,7 +1619,8 @@ private static Double nullToZero(Double value) {
* @return getTopologyLag.
*/
public static Map<String, Map<String, Object>>
getTopologyLag(StormTopology userTopology, Map<String,Object> config) {
- return TopologySpoutLag.lag(userTopology, config);
+ Boolean disableLagMonitoring =
ObjectReader.getBoolean(config.get(DaemonConfig.UI_DISABLE_SPOUT_LAG_MONITORING),
false);
Review comment:
Nit: Consider adding the default to defaults.yaml instead of here. That way
it's obvious to users what the default is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
