HeartSaVioR commented on a change in pull request #2996: STORM-3376: Set Server callback before opening Netty socket, so we do… URL: https://github.com/apache/storm/pull/2996#discussion_r281022538
########## File path: storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java ########## @@ -30,6 +32,7 @@ private Configuration loginConf; private int port; private boolean areWorkerTokensSupported; + private ITransportPlugin transportPlugin; Review comment: We might explicitly set `null` in exception block and still make this `final`, but let me check other fields as well and submit a minor PR. Not a big deal. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services