srdo commented on a change in pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOffset for Kafka Trident spout URL: https://github.com/apache/storm/pull/2911#discussion_r283395439
########## File path: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitterEmitTest.java ########## @@ -26,11 +26,12 @@ import static org.mockito.Mockito.when; import java.util.Collections; +import java.util.HashMap; import java.util.List; import java.util.Map; -import org.apache.kafka.clients.consumer.ConsumerRecord; -import org.apache.kafka.clients.consumer.MockConsumer; -import org.apache.kafka.clients.consumer.OffsetResetStrategy; + +import org.apache.commons.collections.map.HashedMap; +import org.apache.kafka.clients.consumer.*; Review comment: Nit: Please avoid wildcard imports, they make the code harder to read ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
