srdo commented on a change in pull request #3013: fix uploading dependency jars
too slow when storm client and server located in different IDC
URL: https://github.com/apache/storm/pull/3013#discussion_r287830028
##########
File path:
storm-client/src/jvm/org/apache/storm/dependency/DependencyUploader.java
##########
@@ -157,7 +167,14 @@ private boolean uploadDependencyToBlobStore(String key,
File dependency)
AtomicOutputStream blob = null;
try {
blob = getBlobStore().createBlob(key, new
SettableBlobMeta(acls));
- Files.copy(dependency.toPath(), blob);
+// Files.copy(dependency.toPath(), blob);
+
+ /***
+ * By default, {@link java.nio.file.Files#copy(Path,
OutputStream)} copy bytes only 8k each time,
Review comment:
I think this comment should be deleted before we merge, as it only makes
sense when looking at the current diff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
