StaticMian commented on a change in pull request #3013: fix uploading
dependency jars too slow when storm client and server located in different IDC
URL: https://github.com/apache/storm/pull/3013#discussion_r287885643
##########
File path:
storm-client/src/jvm/org/apache/storm/dependency/DependencyUploader.java
##########
@@ -154,10 +160,15 @@ private boolean uploadDependencyToBlobStore(String key,
File dependency)
acls.add(new AccessControl(AccessControlType.OTHER,
BlobStoreAclHandler.READ));
+ InputStream in = null;
AtomicOutputStream blob = null;
try {
+ in = Files.newInputStream(dependency.toPath());
Review comment:
Good idea! But, does two 'try's look pretty? also I want to keep the code
style same with blob...
ok, I'll try the try-with-resources
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
