HeartSaVioR commented on a change in pull request #3011: STORM-3395 Fix
Placeholder Topology page components show task counts
URL: https://github.com/apache/storm/pull/3011#discussion_r288128137
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -4214,6 +4203,22 @@ private void
maybeAddPlaceholderBoltAggStats(TopologyPageInfo topoPageInfo, Stor
}
}
+ private CommonAggregateStats getPlaceholderCommonAggregateStats(Object
component) {
+ // common aggregate
+ CommonAggregateStats commonStats = new CommonAggregateStats();
+
+ // set num_tasks and expected num_executors
+ Map<String, Object> jsonMap = StormCommon.componentConf(component);
+ int numTasks = (int) (long)
jsonMap.getOrDefault(Config.TOPOLOGY_TASKS, 0);
+ commonStats.set_num_executors(numTasks);
Review comment:
Just to double check, is it safe to assume number of executors is same as
number of tasks? If there's safe way to get the value it would be better to
apply that, otherwise 0 (even -1) might make less confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
