Ethanlm commented on a change in pull request #3011: STORM-3395 Fix Placeholder
Topology page components show task counts
URL: https://github.com/apache/storm/pull/3011#discussion_r288288493
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -4214,6 +4203,22 @@ private void
maybeAddPlaceholderBoltAggStats(TopologyPageInfo topoPageInfo, Stor
}
}
+ private CommonAggregateStats getPlaceholderCommonAggregateStats(Object
component) {
+ // common aggregate
+ CommonAggregateStats commonStats = new CommonAggregateStats();
+
+ // set num_tasks and expected num_executors
+ Map<String, Object> jsonMap = StormCommon.componentConf(component);
+ int numTasks = (int) (long)
jsonMap.getOrDefault(Config.TOPOLOGY_TASKS, 0);
+ commonStats.set_num_executors(numTasks);
Review comment:
You can use `StormCommon.numStartExecutors` to get num_executors.
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L2392-L2405
updated `StormBase`
And then when doing scheduling, nimbus gets `component_executors` from
stormBase, and do partition based on `numExecutors` and the list of tasks which
belongs to the components:
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L1815-L1828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
