govind-menon commented on a change in pull request #3022: STORM-3407 Storm 2.x
ConstraintSolverStrategy backward compatibility
URL: https://github.com/apache/storm/pull/3022#discussion_r291715450
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
##########
@@ -290,15 +301,15 @@ public SchedulingResult schedule(Cluster cluster,
TopologyDetails td) {
}
//early detection/early fail
- if (!checkSchedulingFeasibility()) {
+ if (!checkSchedulingFeasibility(daemonMaxStateSearch)) {
Review comment:
nit: rename it to maxStateSearch (it's just the maxStateSearch that has been
determined from the config for this topology)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
