krichter722 commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055250
##########
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##########
@@ -41,7 +45,12 @@
public static final String JMS_TOPIC_SPOUT = "JMS_TOPIC_SPOUT";
public static final String ANOTHER_BOLT = "ANOTHER_BOLT";
- @SuppressWarnings("serial")
+ /**
+ * The main method.
+ * @param args takes the topology name as first argument
+ * @throws Exception any expection occuring durch cluster setup or
operation
+ */
+ @SuppressWarnings({"serial",
"checkstyle:VariableDeclarationUsageDistance"})
Review comment:
In my opinion it's valid to make exceptions if they're thought through.
Especially is the exception is associated with concrete line of code rather
than just represented by a count.
Breaking up this method would reduce it's readability in my opinion. After
all, I don't care, but I'm starting the discussion in order to figure out
whether you're strictly against it (I might do similar work) or whether you
accept it if you agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
