srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055492
##########
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##########
@@ -41,7 +45,12 @@
public static final String JMS_TOPIC_SPOUT = "JMS_TOPIC_SPOUT";
public static final String ANOTHER_BOLT = "ANOTHER_BOLT";
- @SuppressWarnings("serial")
+ /**
+ * The main method.
+ * @param args takes the topology name as first argument
+ * @throws Exception any expection occuring durch cluster setup or
operation
+ */
+ @SuppressWarnings({"serial",
"checkstyle:VariableDeclarationUsageDistance"})
Review comment:
I agree in principle, but in this case the violation is just saying to move
the `jmsTopicProvider` declaration closer to where it is first used. I don't
think you need to break up the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
