kishorvpatil commented on a change in pull request #3030: [STORM-3411] add
parent dir name to downloaded worker log file
URL: https://github.com/apache/storm/pull/3030#discussion_r295393788
##########
File path:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogviewerResponseBuilder.java
##########
@@ -79,12 +79,20 @@ public static Response buildSuccessJsonResponse(Object
entity, String callback,
*/
public static Response buildDownloadFile(File file, Meter
numFileDownloadExceptions) throws IOException {
try {
+ String fname;
+ try {
+ String topoInfo =
file.getParentFile().getParentFile().getName();
+ String port = file.getParentFile().getName();
+ fname = String.format("%s-%s-%s", topoInfo, port,
file.getName());
Review comment:
we should probably have supervisor/hostname added to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
