srdo commented on a change in pull request #3055: STORM-3440: client: fix all
checkstyle warnings
URL: https://github.com/apache/storm/pull/3055#discussion_r299113721
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -906,381 +907,381 @@
/**
* Pacemaker Thrift Max Message Size (bytes).
*/
- @isInteger
- @isPositiveNumber
+ @IsInteger
+ @IsPositiveNumber
public static final String PACEMAKER_THRIFT_MESSAGE_SIZE_MAX =
"pacemaker.thrift.message.size.max";
/**
* Max no.of seconds group mapping service will cache user groups
*/
- @isInteger
+ @IsInteger
public static final String STORM_GROUP_MAPPING_SERVICE_CACHE_DURATION_SECS
= "storm.group.mapping.service.cache.duration.secs";
/**
* List of DRPC servers so that the DRPCSpout knows who to talk to.
*/
- @isStringList
+ @IsStringList
public static final String DRPC_SERVERS = "drpc.servers";
/**
* This port on Storm DRPC is used by DRPC topologies to receive function
invocations and send results back.
*/
- @isInteger
- @isPositiveNumber
+ @IsInteger
+ @IsPositiveNumber
public static final String DRPC_INVOCATIONS_PORT = "drpc.invocations.port";
/**
* The number of times to retry a Nimbus operation.
*/
- @isNumber
+ @IsNumber
public static final String STORM_NIMBUS_RETRY_TIMES =
"storm.nimbus.retry.times";
/**
* The starting interval between exponential backoff retries of a Nimbus
operation.
*/
- @isNumber
+ @IsNumber
public static final String STORM_NIMBUS_RETRY_INTERVAL =
"storm.nimbus.retry.interval.millis";
/**
* The ceiling of the interval between retries of a client connect to
Nimbus operation.
*/
- @isNumber
+ @IsNumber
public static final String STORM_NIMBUS_RETRY_INTERVAL_CEILING =
"storm.nimbus.retry.intervalceiling.millis";
/**
- * The Nimbus transport plug-in for Thrift client/server communication
+ * The Nimbus transport plug-in for Thrift client/server communication.
*/
- @isString
+ @IsString
public static final String NIMBUS_THRIFT_TRANSPORT_PLUGIN =
"nimbus.thrift.transport";
/**
* Which port the Thrift interface of Nimbus should run on. Clients should
connect to this port to upload jars and submit topologies.
*/
- @isInteger
- @isPositiveNumber
+ @IsInteger
+ @IsPositiveNumber
public static final String NIMBUS_THRIFT_PORT = "nimbus.thrift.port";
/**
* Nimbus thrift server queue size, default is 100000. This is the request
queue size , when there are more requests than number of
* threads to serve the requests, those requests will be queued to this
queue. If the request queue size > this config, then the
* incoming requests will be rejected.
*/
- @isInteger
- @isPositiveNumber
+ @IsInteger
+ @IsPositiveNumber
public static final String NIMBUS_QUEUE_SIZE = "nimbus.queue.size";
/**
* Nimbus assignments backend for storing local assignments. We will use
it to store physical plan and runtime storm ids.
*/
- @isString
- @isImplementationOfClass(implementsClass =
org.apache.storm.assignments.ILocalAssignmentsBackend.class)
+ @IsString
+ @ConfigValidationAnnotations.IsImplementationOfClass(implementsClass =
org.apache.storm.assignments.ILocalAssignmentsBackend.class)
Review comment:
Nit: The qualification seems unnecessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
