Ethanlm commented on a change in pull request #3067: STORM-3442 Add owner to
supervisor summary
URL: https://github.com/apache/storm/pull/3067#discussion_r299763034
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -4051,7 +4052,9 @@ public TopologyPageInfo getTopologyPageInfo(String
topoId, String window, boolea
nodeToHost,
workerToResources,
includeSys,
- true); //this is
the topology page, so we know the user is authorized
+ true, //this is the
topology page, so we know the user is authorized
+ null,
+ owner);
Review comment:
With this change, the other `aggWorkerStats` function is no longer used by
anyone and can be removed, or change it to
```
aggWorkerStats(String stormId, String stormName,
Map<Integer, String>
task2Component,
Map<List<Integer>,
Map<String, Object>> beats,
Map<List<Long>,
List<Object>> exec2NodePort,
Map<String, String>
nodeHost,
Map<WorkerSlot,
WorkerResources> worker2Resources,
boolean includeSys,
boolean userAuthorized, String owner)
```
so by default filterSupervisor is null and then it can be used here.
But this is not very important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
