srdo commented on a change in pull request #3074: STORM-3456: cassandra: fix
all checkstyle warnings
URL: https://github.com/apache/storm/pull/3074#discussion_r300828267
##########
File path:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/OpaqueTupleStateMapper.java
##########
@@ -99,6 +98,7 @@ public Values toValues(OpaqueValue<ITuple> tuple) {
prev = null;
}
+ Long currTx = (Long) values.get(index++);
Review comment:
I think this introduces a bug. The index is supposed to be 0 here, but the
for loops above can increment it. Maybe initialize index to 1 above, and then
just do get(0) here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
