krichter722 commented on issue #3084: STORM-3425: Add module UnusedImports to checkstyle configuration URL: https://github.com/apache/storm/pull/3084#issuecomment-509025741 It's better to discard it if you don't feel the need. I did the checkstyle changes as a sort of meditation from which I have no gain except having done it. > By the way, I missed this in your earlier PR to remove JavadocMethod, but please update the comment here https://github.com/apache/storm/blob/master/storm-checkstyle/src/main/resources/storm/storm_checkstyle.xml#L28. Otherwise we will probably accidentally overwrite your changes next time we update Checkstyle. I read this multiple times and I don't get what should be changed and why :) How can changes be overwritten?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
