srdo commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3050#discussion_r303236304
########## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java ########## @@ -12,6 +12,7 @@ package org.apache.storm.scheduler.resource.strategies.scheduling; +import com.google.common.annotations.VisibleForTesting; Review comment: Please use the shaded package ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
