srdo commented on issue #3012: MINOR: Clarify error message when TGT has problems URL: https://github.com/apache/storm/pull/3012#issuecomment-515576405 I think we don't if multiple people have worked on a branch, e.g. if you had made some commits in this branch working alongside Jacob. In that case we don't want to squash to one commit, because we then can't tell who did what. When there's only one author, I don't think squashing is a problem. It looks like Github puts the real author's name on the squashed commit, and then just lists me as the committer. See https://github.com/apache/storm/commit/9f10f8a14482e4eb1c1323ac86d3c373634539c2
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
