srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HdfsBolt, fix storm-hdfs tests not running
URL: https://github.com/apache/storm/pull/2990#discussion_r308393282
##########
File path:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestHdfsBolt.java
##########
@@ -203,6 +204,17 @@ public void testTickTuples() throws IOException {
//Tick should have flushed it
Assert.assertEquals(1, countNonZeroLengthFiles(testRoot));
}
+
+ @Test
+ public void testShutdownStorm3372() {
+ //STORM-3372: Rotation policy other than TimedRotationPolicy causes
NPE on cleanup
Review comment:
Makes sense, changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
