Ethanlm commented on a change in pull request #2878: [STORM-3257] 'storm kill' 
command line should be able to continue on error
URL: https://github.com/apache/storm/pull/2878#discussion_r308712194
 
 

 ##########
 File path: storm-core/src/jvm/org/apache/storm/command/KillTopology.java
 ##########
 @@ -25,21 +25,49 @@
 
     public static void main(String[] args) throws Exception {
         Map<String, Object> cl = CLI.opt("w", "wait", null, CLI.AS_INT)
+                                    .boolOpt("i", "ignore-errors")
 
 Review comment:
   I think it's good to add it as a new option to backwards-compatibility. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to