dandsager1 opened a new pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option URL: https://github.com/apache/storm/pull/3096 Implements One Worker Per Executor Option In the process of implementing, also encountered and fixed 2 bugs - typo in `Cluster:: calculateWorkerResources` incorrectly adds wrong type of memory `totalResources.addOnHeap(shared.get_off_heap_worker());' https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java#L507 - bad cached worker resource value. `Cluster::nodeToScheduledResourcesCache` maps from node to WorkerSlot -> NormalizedResourceRequest. In `Cluster::updateCachesForWorkerSlot` value added was incorrectly adding shared OffHeapNode memory. This could result in overcounting used memory, and subsequent reporting negative resources in `RAS_Node::getTotalAvailableResources.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
