d2r commented on a change in pull request #3050: STORM-3434: server: fix all
checkstyle warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r312710065
##########
File path:
storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java
##########
@@ -90,6 +90,7 @@ public PacemakerServer(IServerMessageHandler handler,
Map<String, Object> config
this.bossEventLoopGroup = new NioEventLoopGroup(1, bossFactory);
// 0 means DEFAULT_EVENT_LOOP_THREADS
//
https://github.com/netty/netty/blob/netty-4.1.24.Final/transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java#L40
+ int maxWorkers = (int) config.get(DaemonConfig.PACEMAKER_MAX_THREADS);
Review comment:
I agree with @srdo on this one. If moving this up one line would cause a
style violation, how about moving it down one line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
