Ethanlm commented on a change in pull request #3112: [STORM-3494] use 
HdfsLoginUtil singleton to login to hdfs
URL: https://github.com/apache/storm/pull/3112#discussion_r316354706
 
 

 ##########
 File path: dev-tools/travis/travis-script.sh
 ##########
 @@ -43,7 +43,7 @@ elif [ "$2" == "External" ]
 then
   if [ "$TRAVIS_JDK_VERSION" == "openjdk11" ]
   then 
-    
TEST_MODULES='!storm-client,!storm-server,!storm-core,!storm-webapp,!storm-shaded-deps,!external/storm-cassandra,!external/storm-hive,!external/storm-hdfs,!external/storm-hbase,!sql/storm-sql-external/storm-sql-hdfs,!external/storm-hdfs-blobstore'
+    
TEST_MODULES='!storm-client,!storm-server,!storm-core,!storm-webapp,!storm-shaded-deps,!external/storm-cassandra,!external/storm-hive,!external/storm-hdfs,!external/storm-hbase,!sql/storm-sql-external/storm-sql-hdfs,!external/storm-hdfs-blobstore,!external/storm-hdfs-login'
 
 Review comment:
   Not sure why we have different `TEST_MODULES` on openjdk11 in first place. I 
added it here because `storm-hdfs-login` is similar to `storm-hdfs-blobstore`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to