krichter722 commented on a change in pull request #3050: STORM-3434: server:
fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r316820128
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
##########
@@ -439,26 +435,26 @@ protected String getWorkerLogWriter(SimpleVersion
topoVersion) {
*/
protected String getWorkerClassPath(String stormJar, List<String>
dependencyLocations, SimpleVersion topoVersion) {
List<String> workercp = new ArrayList<>();
-
workercp.addAll(asStringList(_topoConf.get(Config.TOPOLOGY_CLASSPATH_BEGINNING)));
+
workercp.addAll(asStringList(topoConf.get(Config.TOPOLOGY_CLASSPATH_BEGINNING)));
workercp.addAll(frameworkClasspath(topoVersion));
workercp.add(stormJar);
workercp.addAll(dependencyLocations);
-
workercp.addAll(asStringList(_topoConf.get(Config.TOPOLOGY_CLASSPATH)));
+ workercp.addAll(asStringList(topoConf.get(Config.TOPOLOGY_CLASSPATH)));
return CPJ.join(workercp);
}
private String substituteChildOptsInternal(String string, int memOnheap) {
if (StringUtils.isNotBlank(string)) {
- String p = String.valueOf(_port);
+ String p = String.valueOf(port);
string = string.replace("%ID%", p);
- string = string.replace("%WORKER-ID%", _workerId);
- string = string.replace("%TOPOLOGY-ID%", _topologyId);
+ string = string.replace("%WORKER-ID%", workerId);
+ string = string.replace("%TOPOLOGY-ID%", topologyId);
string = string.replace("%WORKER-PORT%", p);
if (memOnheap > 0) {
string = string.replace("%HEAP-MEM%",
String.valueOf(memOnheap));
}
- if (memoryLimitMB > 0) {
- string = string.replace("%LIMIT-MEM%",
String.valueOf(memoryLimitMB));
+ if (memoryLimitMb > 0) {
Review comment:
I read megabytes in your first post, but now I'm not getting why people
would take it as megabits. I've never seen memory being measured in this unit,
but megabytes or gigabytes instead. I wouldn't worry about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
