agresch commented on a change in pull request #3121: STORM-3479 HB timeout 
configurable on a topology level
URL: https://github.com/apache/storm/pull/3121#discussion_r323398027
 
 

 ##########
 File path: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/WorkerLogs.java
 ##########
 @@ -189,12 +194,29 @@ public String getTopologyOwnerFromMetadataFile(Path 
metaFile) {
      */
     public Set<String> getAliveIds(int nowSecs) throws IOException {
         return 
SupervisorUtils.readWorkerHeartbeats(stormConf).entrySet().stream()
-                .filter(entry -> Objects.nonNull(entry.getValue())
-                        && !SupervisorUtils.isWorkerHbTimedOut(nowSecs, 
entry.getValue(), stormConf))
+                .filter(entry -> Objects.nonNull(entry.getValue()) && 
!isTimedOut(nowSecs, entry))
 
 Review comment:
   SupervisorUtils .isWorkerHbTimedOut() - is this no longer valid?  Should it 
be removed or move the timeout code there?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to