Ethanlm commented on a change in pull request #3144: STORM-3524 create complete
blobstore path in case parent directory ge…
URL: https://github.com/apache/storm/pull/3144#discussion_r335492377
##########
File path:
storm-server/src/main/java/org/apache/storm/localizer/LocalizedResource.java
##########
@@ -254,9 +255,12 @@ public long fetchUnzipToTemp(ClientBlobStore store)
throws IOException, KeyNotFo
if (!Files.exists(parent)) {
//There is a race here that we can still lose
try {
- Files.createDirectory(parent);
+ Files.createDirectories(parent);
} catch (FileAlreadyExistsException e) {
//Ignored
+ } catch (Exception e) {
Review comment:
We can only catch `IOException` here. `Files.createDirectories(parent)` only
throws `IOException`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
