Ethanlm commented on a change in pull request #3146: STORM-3521: Ensures
unrecognized Storm CLI flags/arguments are passed to main Java class if any
URL: https://github.com/apache/storm/pull/3146#discussion_r337067943
##########
File path: storm-client/test/py/test_storm_cli.py
##########
@@ -67,6 +67,26 @@ def test_jar_command(self):
])
)
+ self.mock_execvp.reset_mock()
+
+ self.base_test([
+ 'storm', 'jar', '/path/to/jar.jar', 'some.Topology.Class',
+ '-name', 'run-topology', 'randomArgument', '-randomFlag',
'randomFlagValue', '-rotateSize', '0.0001',
+ '--hdfsConf', 'someOtherHdfsConf',
'dfs.namenode.kerberos.principal.pattern=hdfs/*.EV..COM'
+ ], self.mock_execvp, mock.call(
+ self.java_cmd, [
+ self.java_cmd, '-client','-Ddaemon.name=', '-Dstorm.options=',
+ '-Dstorm.home=' + self.storm_dir + '', '-Dstorm.log.dir=' +
self.storm_dir + "/logs",
Review comment:
Can we delete `+ ''` in `self.storm_dir + ''`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
