Ethanlm commented on a change in pull request #3127: [STORM-3507] add
quarantine area for superviosrs which should have be…
URL: https://github.com/apache/storm/pull/3127#discussion_r337198580
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/DefaultBlacklistStrategy.java
##########
@@ -85,9 +85,10 @@ public void prepare(Map<String, Object> conf) {
}
}
Set<String> toRelease = releaseBlacklistWhenNeeded(cluster, new
ArrayList<>(blacklist.keySet()));
+ cluster.setQuarantinedSupervisors(toRelease);
Review comment:
I don't like this to be a side effect of this `getBlacklist` function. But I
am still looking for a better way to better resolve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services