agresch commented on a change in pull request #3153: STORM-3523 revert handling
of FNF. Add warning for possible localize…
URL: https://github.com/apache/storm/pull/3153#discussion_r339622335
##########
File path:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -213,7 +214,7 @@ private LocalizedResource getUserFile(String user, String
key) {
blobPending.compute(topologyId, (tid, old) -> {
CompletableFuture<Void> ret = old;
if (ret == null) {
- ret = CompletableFuture.supplyAsync(new DownloadBlobs(pna,
cb), execService);
+ ret = CompletableFuture.supplyAsync(new DownloadBlobs(pna,
cb), taskExecService);
Review comment:
No, I don't believe so. The "DownloadBlobs" is basically creating an object
that acts as a task that then waits for a download to finish through the
getBlobs() call. getBlobs() calls and waits on downloadOrUpdate(), which runs
in the download executor.
Here is a callstack for this path from one of the jstacks I took on a
deadlocked supervisor:
Thread 70026: (state = BLOCKED)
- sun.misc.Unsafe.park(boolean, long) @bci=0 (Compiled frame; information
may be imprecise)
- java.util.concurrent.locks.LockSupport.park(java.lang.Object) @bci=14,
line=175 (Interpreted frame)
- java.util.concurrent.CompletableFuture$Signaller.block() @bci=19,
line=1693 (Interpreted frame)
-
java.util.concurrent.ForkJoinPool.managedBlock(java.util.concurrent.ForkJoinPool$ManagedBlocker)
@bci=59, line=3313 (Interpreted frame)
- java.util.concurrent.CompletableFuture.waitingGet(boolean) @bci=129,
line=1729 (Interpreted frame)
- java.util.concurrent.CompletableFuture.get() @bci=11, line=1895
(Interpreted frame)
- org.apache.storm.localizer.AsyncLocalizer.getBlobs(java.util.List,
org.apache.storm.localizer.PortAndAssignment,
org.apache.storm.localizer.BlobChangingCallback) @bci=226, line=557
(Interpreted frame)
-
org.apache.storm.localizer.AsyncLocalizer.addReferencesToBlobs(org.apache.storm.localizer.PortAndAssignment,
org.apache.storm.localizer.BlobChangingCallback) @bci=19, line=383
(Interpreted frame)
-
org.apache.storm.localizer.AsyncLocalizer.lambda$null$7(org.apache.storm.localizer.PortAndAssignment,
org.apache.storm.localizer.BlobChangingCallback, java.lang.String,
java.lang.String, java.util.concurrent.CompletableFuture) @bci=34, line=218
(Interpreted frame)
-
org.apache.storm.localizer.AsyncLocalizer$$Lambda$75.apply(java.lang.Object,
java.lang.Object) @bci=24 (Interpreted frame)
- java.util.concurrent.ConcurrentHashMap.compute(java.lang.Object,
java.util.function.BiFunction) @bci=298, line=1877 (Interpreted frame)
-
org.apache.storm.localizer.AsyncLocalizer.lambda$requestDownloadTopologyBlobs$8(java.lang.String,
org.apache.storm.localizer.PortAndAssignment,
org.apache.storm.localizer.BlobChangingCallback, java.lang.Void) @bci=14,
line=212 (Interpreted frame)
-
org.apache.storm.localizer.AsyncLocalizer$$Lambda$73.apply(java.lang.Object)
@bci=20 (Interpreted frame)
-
java.util.concurrent.CompletableFuture.uniCompose(java.util.concurrent.CompletableFuture,
java.util.function.Function,
java.util.concurrent.CompletableFuture$UniCompose) @bci=84, line=952
(Interpreted frame)
- java.util.concurrent.CompletableFuture$UniCompose.tryFire(int) @bci=29,
line=926 (Interpreted frame)
- java.util.concurrent.CompletableFuture$Completion.exec() @bci=2, line=443
(Interpreted frame)
- java.util.concurrent.ForkJoinTask.doExec() @bci=10, line=289 (Interpreted
frame)
-
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(java.util.concurrent.ForkJoinTask)
@bci=21, line=1056 (Interpreted frame)
-
java.util.concurrent.ForkJoinPool.runWorker(java.util.concurrent.ForkJoinPool$WorkQueue)
@bci=35, line=1692 (Interpreted frame)
- java.util.concurrent.ForkJoinWorkerThread.run() @bci=24, line=157
(Interpreted frame)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
