agresch commented on a change in pull request #3160: STORM-3530 Improve
scheduling failure messages
URL: https://github.com/apache/storm/pull/3160#discussion_r340623940
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
##########
@@ -126,7 +135,9 @@ protected boolean scheduleExecutor(
} else {
String comp = td.getExecutorToComponent().get(exec);
NormalizedResourceRequest requestedResources =
td.getTotalResources(exec);
- LOG.error("Not Enough Resources to schedule Task {} - {} {}",
exec, comp, requestedResources);
+ schedulingFailText = "Not Enough Resources to schedule Task "
+ + exec + " - " + comp + " " + requestedResources;
+ LOG.error(schedulingFailText);
Review comment:
Can we make this a warn message? It's always bothered me that this reports
as an ERROR. There's no error in the code flow, the cluster just does not have
enough resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
