Ethanlm commented on a change in pull request #3153: STORM-3523 revert handling
of FNF. Prevent AsyncLocalizer deadlock.
URL: https://github.com/apache/storm/pull/3153#discussion_r340794437
##########
File path:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -213,7 +214,7 @@ private LocalizedResource getUserFile(String user, String
key) {
blobPending.compute(topologyId, (tid, old) -> {
CompletableFuture<Void> ret = old;
if (ret == null) {
- ret = CompletableFuture.supplyAsync(new DownloadBlobs(pna,
cb), execService);
+ ret = CompletableFuture.supplyAsync(new DownloadBlobs(pna,
cb), taskExecService);
Review comment:
Your explanation makes sense.
The stack trace seems to irrelevant though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
