Ethanlm commented on a change in pull request #3185: STORM-3557 allow health
checks to pass on timeout and add meter to track
URL: https://github.com/apache/storm/pull/3185#discussion_r363396520
##########
File path:
storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java
##########
@@ -40,7 +45,7 @@
private static final String TIMEOUT = "timeout";
private static final String FAILED_WITH_EXIT_CODE =
"failed_with_exit_code";
- public static int healthCheck(Map<String, Object> conf) {
+ public static int healthCheck(Map<String, Object> conf, Supervisor
supervisor) {
Review comment:
We only need `metricsRegistry` here instead of `Supervisor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
