agresch commented on a change in pull request #3184: STORM-3555 add meter to
track errors killing workers
URL: https://github.com/apache/storm/pull/3184#discussion_r363520132
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
##########
@@ -528,6 +532,9 @@ void killWorkers(Collection<String> workerIds,
ContainerLauncher launcher) throw
long start = Time.currentTimeMillis();
while (!k.areAllProcessesDead()) {
if ((Time.currentTimeMillis() - start) > 10_000) {
+ if (killErrorMeter != null) {
+ killErrorMeter.mark();
+ }
Review comment:
Supervisor.java that I modified, or line 539 of Supervisor.java on master
currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
