kishorvpatil commented on a change in pull request #3194: [STORM-3565] add support for adding dimensions to metric data points URL: https://github.com/apache/storm/pull/3194#discussion_r367405335
########## File path: storm-client/src/jvm/org/apache/storm/metric/api/IDimensionalMetric.java ########## @@ -0,0 +1,32 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version + * 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions + * and limitations under the License. + */ + +package org.apache.storm.metric.api; + +import java.util.Map; + +public interface IDimensionalMetric extends IMetric { + + /** + * Dimensions is a collection of additional key-value metadata which is optional. + * It could be useful for further fine-grained measurement for a metric. + * It may also help better grouping in downstream metric monitoring system. + * + * @return a map of dimension name to a sub-metric + */ + Map<Map<String, String>, CountMetric> getDimToMetric(); // dimensions : sub-metric Review comment: Using `CountMetric` makes this interface specific to `CountMetric`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
