Ethanlm commented on a change in pull request #3195: [STORM-3567] fix UI
showing wrong resource info when topo is not scheduled
URL: https://github.com/apache/storm/pull/3195#discussion_r368141346
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -4242,20 +4231,30 @@ public TopologyPageInfo getTopologyPageInfo(String
topoId, String window, boolea
}
/**
- * Add placeholder AggStats allowing topology page to show components
before AggStats are populated.
+ * If aggStats are not populated, compute common and component(spout) agg
and create placeholder stat.
+ * This allow the topology page to show component spec even the topo is
not scheduled.
+ * Otherwise, just fetch data from current topoPageInfo.
*
* @param topoPageInfo topology page info holding spout AggStats
* @param topology storm topology used to get spout names
*/
- private void maybeAddPlaceholderSpoutAggStats(TopologyPageInfo
topoPageInfo, StormTopology topology) {
+ private void addSpoutAggStats(TopologyPageInfo topoPageInfo, StormTopology
topology, Map<String, Object> topoConf) {
Review comment:
Nit: Java doc is missing @param topology topoConf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
