Ethanlm commented on a change in pull request #3202: STORM-3572 prevent NPEs
when doing visualization with restarting exec…
URL: https://github.com/apache/storm/pull/3202#discussion_r374183536
##########
File path: storm-server/src/main/java/org/apache/storm/stats/StatsUtil.java
##########
@@ -830,6 +830,9 @@ private static TopologyPageInfo postAggregateTopoStats(Map
task2comp, Map exec2n
Map<String, Map<K, Double>> ret = new HashMap<>();
Map<String, Map<K, List>> expands = expandAveragesSeq(avgSeq,
countSeq);
+ if (expands == null) {
Review comment:
this is not needed since `expandAveragesSeq` will not return null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
