Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c
option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378389660
##########
File path: storm-core/src/jvm/org/apache/storm/command/Rebalance.java
##########
@@ -57,6 +58,15 @@ public static void main(String[] args) throws Exception {
}
Map<String, Object> confOverrides = (Map<String, Object>) cl.get("t");
+ Map<String, Object> jvmOpts = Utils.readCommandLineOpts(); // values
in -Dstorm.options (originally -c in storm.py)
Review comment:
This is mostly a question: Do we want to include default `storm.yaml` into
this too?
for example:
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/command/ShellSubmission.java#L35
this reads `storm.yaml` and commandLineOpts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
