Ethanlm commented on a change in pull request #3211: [STORM-3584] Support
getting version info from a wildcard classpath entry
URL: https://github.com/apache/storm/pull/3211#discussion_r382645447
##########
File path: storm-client/src/jvm/org/apache/storm/utils/VersionInfo.java
##########
@@ -172,7 +172,10 @@ private static IVersionInfo getFromClasspath(List<String>
classpath, final Strin
try {
Path parent = p.getParent();
List<String> children = new ArrayList<>();
- Files.list(parent).forEach(path ->
children.add(path.toString()));
+ Files.list(parent)
+ //avoid infinite recursion
Review comment:
infinite recursion can happen if there is a file named `*` under
`/<parent-path>/` directory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
