bipinprasad commented on a change in pull request #3212: [STORM-3587] Allow
Scheduler futureTask to gracefully exit with higher timeout.
URL: https://github.com/apache/storm/pull/3212#discussion_r382823950
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/User.java
##########
@@ -79,15 +79,18 @@ public String getId() {
return ret;
}
- public void markTopoUnsuccess(TopologyDetails topo, Cluster cluster) {
+ public void markTopoUnsuccess(TopologyDetails topo, Cluster cluster,
String msg) {
unsuccess.add(topo);
if (cluster != null) {
- cluster.setStatus(topo.getId(), "Scheduling Attempted but topology
is invalid");
+ if (msg == null) {
+ msg = "Scheduling Attempted but topology is invalid";
Review comment:
That message is a generic default - same as prior default. I believe there
is one other caller to this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
