Ethanlm commented on a change in pull request #3215: Storm3585 - New compact
Constraint config including maxCoLocationCnt
URL: https://github.com/apache/storm/pull/3215#discussion_r387881742
##########
File path: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java
##########
@@ -541,6 +547,127 @@ public void testMapEntryCustomAnnotation() throws
InvocationTargetException, NoS
}
}
+ @Test
+ public void testExactlyOneOfCustomAnnotation() throws
InvocationTargetException, NoSuchMethodException, NoSuchFieldException,
Review comment:
They should be removed since they are not needed. But we don't have to
remove them from other tests in this PR since they are old code and not
harmful. They can be done in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services