Ethanlm commented on a change in pull request #3215: Storm3585 - New compact
Constraint config including maxNodeCoLocationCnt and incompatibleComponents
URL: https://github.com/apache/storm/pull/3215#discussion_r387968031
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -304,15 +307,38 @@
// an error will be thrown by nimbus on topology submission and not by the
client prior to submitting
// the topology.
public static final String TOPOLOGY_SCHEDULER_STRATEGY =
"topology.scheduler.strategy";
+
/**
- * Declare scheduling constraints for a topology used by the constraint
solver strategy. A List of pairs (also a list) of components
- * that cannot coexist in the same worker.
+ * Declare scheduling constraints for a topology used by the constraint
solver strategy. The format can be either
+ * old style (validated by ListOfListOfStringValidator.class or the newer
style, which is a list of specific type of
+ * Maps (validated by RasConstraintsTypeValidator.class). The value must
be in one or the other format.
+ *
+ * <p>
+ * Old style Config.TOPOLOGY_RAS_CONSTRAINTS (ListOfListOfString)
specified a list of components that cannot
+ * co-exist on the same Worker.
+ * </p>
+ *
+ * <p>
+ * New style Config.TOPOLOGY_RAS_CONSTRAINTS is map where each component
has a list of other incompatible components
+ * (which serves the same function as the old style configuration) and
optional number that specifies
+ * the maximum co-location count for the component on a node.
+ * </p>
+ *
+ * <p>comp-1 cannot exist on same worker as comp-2 or comp-3, and at most
"2" comp-1 on same node</p>
+ * <p>comp-2 and comp-4 cannot be on same node (missing comp-1 is implied
from comp-1 constraint)</p>
Review comment:
typo: "node" -> "worker"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
