bipinprasad commented on a change in pull request #3215: Storm3585 - New
compact Constraint config including maxNodeCoLocationCnt and
incompatibleComponents
URL: https://github.com/apache/storm/pull/3215#discussion_r390722185
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestConstraintSolverStrategy.java
##########
@@ -54,27 +58,70 @@
import org.apache.storm.metric.StormMetricsRegistry;
import org.apache.storm.scheduler.resource.normalization.ResourceMetrics;
+@RunWith(Parameterized.class)
public class TestConstraintSolverStrategy {
+ @Parameters
+ public static Object[] data() {
+ return new Object[] { false, true };
+ }
+
private static final Logger LOG =
LoggerFactory.getLogger(TestConstraintSolverStrategy.class);
private static final int MAX_TRAVERSAL_DEPTH = 2000;
private static final int NORMAL_BOLT_PARALLEL = 11;
//Dropping the parallelism of the bolts to 3 instead of 11 so we can find
a solution in a reasonable amount of work when backtracking.
private static final int BACKTRACK_BOLT_PARALLEL = 3;
+ private static final int CO_LOCATION_CNT = 2;
- public Map<String, Object> makeTestTopoConf() {
+ // class members
+ public Boolean consolidatedConfigFlag = Boolean.TRUE;
+
+ public TestConstraintSolverStrategy(boolean consolidatedConfigFlag) {
+ this.consolidatedConfigFlag = consolidatedConfigFlag;
+ LOG.info("Running tests with consolidatedConfigFlag={}",
""+consolidatedConfigFlag);
Review comment:
fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
